]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
NotificationDaemon: fix typo in dealing with TrayIcon
authorGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 23 Mar 2011 20:37:05 +0000 (21:37 +0100)
committerGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 23 Mar 2011 21:58:28 +0000 (22:58 +0100)
Source was failing to determine if it was a tray icon, destroying
itself when the associated application was closed.

https://bugzilla.gnome.org/show_bug.cgi?id=645625

js/ui/notificationDaemon.js

index f8f356e8ab0b31bea556b06d8e6a52c0c1763f87..c3ae212ac5218e24533c6246801f4365b40c6b76 100644 (file)
@@ -519,10 +519,13 @@ Source.prototype = {
     _appStateChanged: function() {
         // Destroy notification sources when their apps exit.
         // The app exiting would normally result in a tray icon being removed,
-        // so it should be ok to destroy the source associated with a tray icon
-        // here too, however we just let that happen through the code path
-        // associated with the tray icon being removed.
-        if (!this._isTrayIcon && this.app.get_state() == Shell.AppState.STOPPED)
+        // so the associated source would be destroyed through the code path
+        // that handles the tray icon being removed. We should not destroy
+        // the source associated with a tray icon when the application state
+        // is Shell.AppState.STOPPED because running applications that have
+        // no open windows would also have that state. This is often the case
+        // for applications that use tray icons.
+        if (!this._trayIcon && this.app.get_state() == Shell.AppState.STOPPED)
             this.destroy();
     },